Jonas Hellström, Jenny Andersén, Emelie Nyberg Kedert#43
Open
EmelieNyberg wants to merge 7 commits intoTechnigo:mainfrom
Open
Jonas Hellström, Jenny Andersén, Emelie Nyberg Kedert#43EmelieNyberg wants to merge 7 commits intoTechnigo:mainfrom
EmelieNyberg wants to merge 7 commits intoTechnigo:mainfrom
Conversation
JennieDalgren
approved these changes
Sep 27, 2024
JennieDalgren
left a comment
JennieDalgren
left a comment
There was a problem hiding this comment.
Great job with this project!
Clear variable/function names and helpful comments.
Good structure in the CSS
Great use of semantic elements in the HTML
I can't find anything for you to improve. Maybe some UX, when filtering on for example sci-fi and then sorting on latest. The whole librbary is shown but I would expect only sci-fi books would still show since that is "colored in blue"
Keep up the good work!! ⭐️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://readcloud.netlify.app/
Collaborators
Emelie Nyberg Kedert
Jonas Hellström
Jenny Andersén
[EmelieNyberg, Jonash189, jempa182]